Skip to content

Fix issues with parsing and evaluating vertex selectors#313

Merged
Entenwilli merged 1 commit intomainfrom
selector-fix
Jul 18, 2025
Merged

Fix issues with parsing and evaluating vertex selectors#313
Entenwilli merged 1 commit intomainfrom
selector-fix

Conversation

@Entenwilli
Copy link
Copy Markdown
Member

This PR fixes issues with parsing and evaluating vertex selectors in the analysis DSL.
This was caused by incorrect evaluation of normal vertex selectors and additionally different necessary evaluation logic for a group of selectors.

Additionally, this PR introduces some tests to prevent regressions.
This PR closes #304

@Entenwilli Entenwilli added this to the 5.0.0 milestone Jul 15, 2025
@Entenwilli Entenwilli self-assigned this Jul 15, 2025
@Entenwilli Entenwilli added bug Something isn't working core Related to the core DFD/PCM data flow analysis labels Jul 15, 2025
Copy link
Copy Markdown
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Entenwilli Entenwilli merged commit 8263bcc into main Jul 18, 2025
1 check passed
@Entenwilli Entenwilli deleted the selector-fix branch July 18, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working core Related to the core DFD/PCM data flow analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnlineEditor does not support "... neverflows vertex Labeltype1.x,Labeltype1.y"

2 participants