Monorepo migration#290
Conversation
Converter fix
|
@Entenwilli There are a lot of ResourceProvider error in testing after the migration. Interestingly these do not occur for me locally. Could you also have a look into this? I am currently also looking for a solution. Locally the following happens:
|
I don't have any issues at all when running locally. Not in Eclipse, IntelliJ nor Maven. Are you sure you imported all projects from the same repo and don't have any from the (now) merged repos (e.g. Example Models, Converter) |
Probably some local caching or something on my end. For clarification, you have no problem running the build of this branch locally? Even with all the tests failing here on Github? |
|
The workflow fails here on GitHub, because of some incorrect formatting, not because some tests failed to run |
|
Yes, the build does not fail, but look into the log/console output... there are a lot of error messages of this type:
After looking into other builds, I am quite certain these were not present. |
|
Yes, this is likely caused by changes made in the example models. Eclipse automatically adds these elements to PCM models when they are opened. |
|
Still they should be fixed... I did not touch any of the models, just migrating them to this repository. |
|
I would actually wait before merging this PR, as it rewrites the history a bit and definitly leads to conflicts in the other !5! open PRs |
|
Of the "5" other PRs, 2 are drafts, 1 has been open since last year (and adds documentation) and 1 only changes one single file. I will not postpone this migration for some drafts, documentation changes or minimal fixes. The earlier we start working with this version (also for changes in other migrated repos) the better. |
Entenwilli
left a comment
There was a problem hiding this comment.
One smaller discussion point about the tests originating from the DFD Metamodel Repo
|
Another thing: Should we commit the generated code and model files for the metamodels? They could be built automatically using MWE2 (this would however complicate the building process). |
There a several pros and cons to whatever you do. But lets discuss later. The funny thing with the formatting is that we still generate everything, and spotless will fail checking the generated code regardless. |
|
🎉 |
This addresses #275.