Implement Named Constraints#288
Conversation
73398e2 to
6a550a6
Compare
01Parzival10
left a comment
There was a problem hiding this comment.
It's important that the name can be accessed in DSLResult. Without a link between violation and constraint, batch processing becomes tedious.
|
@Nicolas-Boltz and I discussed the implications of changing the format and we have the following proposal:
By doing this, we both unify the formats but also require to we always name constraints (which significantly helps the understandability a couple of years later) and we also simplify the web editor. The constraints window than simply shows a multiline text editor without the need to manually add constraint entries (which is bad UI, as discussed in our last meeting). Example for a valid constraint: |
As a |
Done in 057224b. I however would opt for using |
|
Thank you. We intentionally choose the asterisk as it is less common in names (especially compared to the dash used to combine words), and additionally, the asterisk is already reserved as wildcard. However, allowing both would also be fine. |
|
I would implement both, but just as a note (and consideration): Considering this, would we still allow both? |
I could build around it. But for the sake of traceability I'd prefer a link between Result and Constraint |
057224b to
6fa9efb
Compare
This PR implements named constraints, so they can be displayed to the user in a more intuitive manner.
However, there are still some discussion points (please provide your opinion on the following, @01Parzival10 @sebinside @Nicolas-Boltz):
DataOwnership: data Sensitivity.Personal neverFlows Location.nonEUwould create a constraint namedDataOwnership