Skip to content

Add Unit Tests and Integrate Example Models Testing Framework#260

Merged
Nicolas-Boltz merged 34 commits intomainfrom
unit-testing
May 6, 2025
Merged

Add Unit Tests and Integrate Example Models Testing Framework#260
Nicolas-Boltz merged 34 commits intomainfrom
unit-testing

Conversation

@Entenwilli
Copy link
Copy Markdown
Member

@Entenwilli Entenwilli commented Mar 18, 2025 •
edited
Loading

Warning

This PR is finished. Please use this PR with the integrastion-testing-framework of https://github.com/DataFlowAnalysis/ExampleModels
This PR depends on DataFlowAnalysis/ExampleModels#17

This PR adds unit tests for several classes responsible for the PCM analysis. Additionally, this PR integrates the Testing Framework provided by this PR

@Entenwilli Entenwilli self-assigned this Mar 18, 2025
@Entenwilli Entenwilli added enhancement New feature or request testing Related to testing and test cases or models core Related to the core DFD/PCM data flow analysis labels Mar 18, 2025
@Entenwilli Entenwilli added this to the 5.0.0 milestone Mar 18, 2025
@Entenwilli Entenwilli force-pushed the unit-testing branch 3 times, most recently from 5995c29 to 545fa8a Compare March 30, 2025 12:02
@Entenwilli Entenwilli changed the title Add PCM Unit Tests and Integrate Example Models Testing Framework Add Unit Tests and Integrate Example Models Testing Framework Apr 22, 2025
Nicolas-Boltz and others added 15 commits May 2, 2025 12:20
@Nicolas-Boltz @Entenwilli
Merge pull request #231 from DataFlowAnalysis/dsl-serialization
7ee9d56 
Allow Serialization and Deserialization of DSL from and to String
@Entenwilli
feat(pcm): add tests for characteristics and data flow variables
ca1527d
@Entenwilli
test: add baseline model integration testing framework
3a7fa90
@Entenwilli
test(examplemodels): clean up example models structure
4d0419d
@Entenwilli
test(integration): remove dependency on unique ids
8dbc904
@Entenwilli
feat(core): remove unique identifiers from vertices
b49176d
@Entenwilli
chore: merge upstream changes
e367b42
@Entenwilli
test(core): implement unit tests for transpose flow graph
b82683c
@Entenwilli
test(core): add unit tests for abstract vertex
45b7fc5
@Entenwilli
test(core): implement the integration testing framework from the exam…
e868e8c 
…ple models repository
@Entenwilli
refactor(dfd): refactor code after rebase
25a3fec
@Entenwilli
fix(dsl): fix wrong results with data characteristics selector
70a04b3
@Entenwilli
feat(pcm): add support for NOT in assignments
1c1211d
@Entenwilli
feat(tests): update testmodels from testmodel PR in example models
1aad77b
@Entenwilli
refactor(tests): update tests after refactoring into packages
c3f7a11
Entenwilli added 12 commits May 2, 2025 12:39
@Entenwilli
test(unit): add unit test for PCM data characteristics calculator
b185a31
@Entenwilli
fix(pcm): prevent references to blank variables in StoEx; Fix node ch…
9848142 
…aracteristics visibility
@Entenwilli
refactor(dsl): parse source selectors in the container class instead …
756090d 
…of the top level class
@Entenwilli
fix(dsl): fix missing walk back when parsing vertex selector
5656ecb
@Entenwilli
test(dsl): ensure that selectors are parsed fully and return the same…
4debab9 
… selector
@Entenwilli
test(dsl): add test for parsing both or either types of source selectors
9640176
@Entenwilli
test(dsl): fix incorrect assertion for data selectors
e0e5ada
@Entenwilli
fix(dsl): reorder parsing of data characteristics to ensure that list…
225b1d7 
…s are prefered over single
@Entenwilli
fix(dsl): ensure all elements are present in characteristic list sele…
ca33c64 
…ctors
@Entenwilli
test(pcm): test vertex characteristics calculator
efbba49
@Entenwilli
fix(dfd): fix issues introduced by rebasing incorrect changes to simp…
18e4750 
…le finder
@Entenwilli
test(demo): fix paths according to refactor of example models
8f36996
@Entenwilli Entenwilli requested review from Nicolas-Boltz, sebinside and uuqjz and removed request for sebinside May 2, 2025 10:54
@Entenwilli Entenwilli marked this pull request as ready for review May 2, 2025 10:55
@Entenwilli Entenwilli mentioned this pull request May 2, 2025
Merged
@Entenwilli
Copy link
Copy Markdown
Member Author

Entenwilli commented May 2, 2025

@sebinside This PR can be reviewed together with DataFlowAnalysis/ExampleModels#17.
They can be merged, but due to the way I worked on them, they depend on each other, oops :D

@Entenwilli Entenwilli mentioned this pull request May 3, 2025
Merged
Nicolas-Boltz
Nicolas-Boltz requested changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Nicolas-Boltz Nicolas-Boltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For @sebinside for "second review".

Comment thread ...aflowanalysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/AbstractPCMVertex.java Outdated
Comment thread ...nalysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/PCMDataCharacteristicsCalculator.java
Comment thread ...flowanalysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/user/UserPCMVertex.java Outdated
Comment thread ...lysis.analysis.pcm/src/org/dataflowanalysis/analysis/pcm/core/user/CallingUserPCMVertex.java Outdated
Comment thread ....analysis.tests/src/org/dataflowanalysis/analysis/tests/unit/mock/DummyResourceProvider.java
@Entenwilli Entenwilli requested a review from Nicolas-Boltz May 6, 2025 10:25
@Nicolas-Boltz Nicolas-Boltz merged commit 293d486 into main May 6, 2025
1 check failed
@Nicolas-Boltz Nicolas-Boltz deleted the unit-testing branch May 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nicolas-Boltz Nicolas-Boltz Nicolas-Boltz approved these changes

@sebinside sebinside Awaiting requested review from sebinside

@uuqjz uuqjz Awaiting requested review from uuqjz

Assignees

@Entenwilli Entenwilli

Labels

core Related to the core DFD/PCM data flow analysis enhancement New feature or request testing Related to testing and test cases or models

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Entenwilli @Nicolas-Boltz @01Parzival10