Skip to content

Combine createRandomBlock functions into one.#258

Merged
leventeliu merged 2 commits intobetafrom
feature/combine_test_funcs
Feb 18, 2019
Merged

Combine createRandomBlock functions into one.#258
leventeliu merged 2 commits intobetafrom
feature/combine_test_funcs

Conversation

@laodouya
Copy link
Member

@laodouya laodouya commented Feb 18, 2019

  1. Rename createRandomBlock functions to types.CreateRandomBlock
  2. Replace all createRandomBlock to reuse types.CreateRandomBlock
  3. Refactor createRandomBlock() in sqlchain/xxx_test.go to reuse types.CreateRandomBlock

@laodouya laodouya changed the title [WIP] Combine createRandomBlock functions into one. Combine createRandomBlock functions into one. Feb 18, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Feb 18, 2019
@CovenantSQL CovenantSQL deleted a comment from codecov bot Feb 18, 2019
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #258 into beta will decrease coverage by 0.12%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##             beta     #258      +/-   ##
==========================================
- Coverage   78.97%   78.85%   -0.13%     
==========================================
  Files         159      159              
  Lines       11955    11981      +26     
==========================================
+ Hits         9442     9448       +6     
- Misses       1828     1846      +18     
- Partials      685      687       +2

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leventeliu leventeliu merged commit b0c46a4 into beta Feb 18, 2019
@leventeliu leventeliu deleted the feature/combine_test_funcs branch February 18, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants