Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Cape Town class_1-Andile_Masela java core1 week1 - #34

Closed
Andile-coder wants to merge 8 commits into
CodeYourFuture:masterfrom
Andile-coder:master
Closed

Cape Town class_1-Andile_Masela java core1 week1#34
Andile-coder wants to merge 8 commits into
CodeYourFuture:masterfrom
Andile-coder:master

Conversation

@Andile-coder

Copy link
Copy Markdown

Your Details

  • Your Name: Andile
  • Your City: Cape Town
  • Your Slack Name: Andile Masela

Homework Details

  • Module: java core 1
  • Week:1

must fix l-function
check l-functions
check magic 8 ball
magic 8-ball still not updated.

@JarrodBen JarrodBen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a result from K-functions-parameters/exercise.js and just some missing text for the answer to K-functions-parameters/exercise3.js, other than that you seem to understand what's to be expected from you, I would suggest giving the exact answers that they require and experiment on those exercises at you own leisure and I like how you change the comment variables to letiables, nice trick. Keep up the good work!

completed  the magic-8-ball,but still not sure if i did correct thing
var mentor5 = "Yohannes";

function capitalLetter(name) {
return (name = name.toUpperCase());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just write return name.toUpperCase();

@dschouw

dschouw commented Mar 22, 2021

Copy link
Copy Markdown

Javascript Core 1 - Week 1 Feedback

Well done on completing the homework Andile!
I've added some comments below and marked this assignment as Returned on Google Classroom.
Please feel free to reach out to me on Slack or Email if anything is unclear.

Git Status

Total Commits : 8

Exercises Comments

  1. Suggestion
    Total number of git commits is a bit low. I would suggest you commit early and commit often as you complete exercises.

  2. Issue L-functions-nested
    Function capitalLetter is returning the name capitalized and assigning it all in the return statement.

    function capitalLetter(name) {
     return (name = name.toUpperCase());   
    } 

    Maybe the function could work by returning the parameter capitalized, without the assignment.

Mandatory Homework Comments

Issue 1-syntax-errors.js

  1. The exercise fails one test because of a missing space character.
  2. Function getTotal correctly adds the two parameters but then does not return it, instead returning a string literal. Have a look at the return statement and see if you can spot the issue.

Excellent work on completing the extra exercises as well

Links

  1. Lesson
  2. Code Your Future Coding Style guidelines

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label May 13, 2021
@github-actions github-actions Bot closed this May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants