This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London Class 8 - Harsheek Thanki - JavaScript Core 1 - Week 1 - #281
Closed
HThanki wants to merge 3 commits into
Closed
London Class 8 - Harsheek Thanki - JavaScript Core 1 - Week 1#281HThanki wants to merge 3 commits into
HThanki wants to merge 3 commits into
Conversation
Author
|
Hi @jackhclee, please could you review this older PR when you get a chance please. Thanks |
jackhclee
reviewed
May 23, 2022
| ...negative, | ||
| ...veryNegative, | ||
| ]; | ||
| return allAnswers[Math.round(Math.random() * allAnswers.length)]; |
There was a problem hiding this comment.
Thank you so much for your resubmission and I should have found out it much earlier! Nice and quality work as before. Refer to line 80, the function should log "The ball has shaken" to console when it is called
jackhclee
reviewed
May 23, 2022
| There are some Tests in this file that will help you work out if your code is working. | ||
|
|
||
| To run the tests for just this one file, type `npm test -- --testPathPattern 3-magic-8-ball` into your terminal | ||
| To run these tests type `npm run extraTo run the tests for just this one file, type `npm run extra-tests -- --testPathPattern 3-magic-8-ball` into your terminal |
There was a problem hiding this comment.
You need to change the package.json if you want to run all tests. See Marina's work for the changes on the 3-magic-8-ball.js and package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?