Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/B-hello-world/exercise.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
console.log("Hello world");
console.log("Hello World. I just started learning JavaScript!");
4 changes: 4 additions & 0 deletions exercises/C-variables/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Start by creating a variable `greeting`
var greeting = "Hello world";


console.log(greeting);
console.log(greeting);
console.log(greeting);
6 changes: 5 additions & 1 deletion exercises/D-strings/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Start by creating a variable `message`

console.log(message);
var message = "This is a string";
var messageType = typeof message;

console.log(message);
console.log(messageType);
6 changes: 5 additions & 1 deletion exercises/E-strings-concatenation/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Start by creating a variable `message`

console.log(message);
var greetingStart = "Hello, my name is ";
var name = "Abed";
var greeting = greetingStart + name;

console.log(greeting);
6 changes: 5 additions & 1 deletion exercises/F-strings-methods/exercise.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Start by creating a variable `message`
var name = "Abed ";
var nameLength = name.length;
var nameLowerCase = name.trim().toLowerCase();

console.log(message);

console.log("My name is " + nameLowerCase + " and my name is " + nameLength + " characters long" );
7 changes: 5 additions & 2 deletions exercises/F-strings-methods/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
const name = " Daniel ";
var name = "Abed ";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, nice to see you experimenting with string methods too :)

var nameLength = name.length;
var nameLowerCase = name.trim().toLowerCase();

console.log(message);

console.log("My name is " + nameLowerCase + " and my name is " + nameLength + " characters long" )
5 changes: 5 additions & 0 deletions exercises/G-numbers/exercise.js
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
// Start by creating a variables `numberOfStudents` and `numberOfMentors`
var numberOfStudents = 15 ;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent with your semi-colons, Although they are not always required, I would suggest that you always use them until you learn more about the nuances of JavaScript's automatic semicolon insertion. Also, no need for spaces before semi-colons. Otherwise good work.

var numberOfMentors = 8 ;
var sum = numberOfStudents + numberOfMentors
//Total numnber of students and mentors: 23
console.log("Total numnber of students and mentors: " + sum)
9 changes: 9 additions & 0 deletions exercises/I-floats/exercise.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,11 @@
var numberOfStudents = 15;
var numberOfMentors = 8;
var sum = numberOfStudents + numberOfMentors;

var PercentageStudents = numberOfStudents / sum ;
var PercentageMentors = numberOfMentors / sum;


console.log("Percentage students: " + Math.round(PercentageStudents*100) + "%")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to evaluate the percentages and then pass the final values to console.log, rather that rounding the floats inside console.log, but otherwise good work.

console.log("Percentage mentors: " + Math.round(PercentageMentors*100) + "%")

1 change: 1 addition & 0 deletions exercises/J-functions/exercise.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
function halve(number) {
// complete the function here
return number / 2;
}

var result = halve(12);
Expand Down
1 change: 1 addition & 0 deletions exercises/J-functions/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
function triple(number) {
// complete function here
return number * 3;
}

var result = triple(12);
Expand Down
36 changes: 35 additions & 1 deletion exercises/K-functions-parameters/exercise.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,43 @@
// Complete the function so that it takes input parameters
function multiply() {
function multiply(x,y) {
// Calculate the result of the function and return it
return x*y ;
}

// Assign the result of calling the function the variable `result`
var result = multiply(3, 4);

console.log(result);

// Declare your function first
function divide(x,y){

return x/y;
}
var result = divide(3, 4);
console.log(result);


// Write your function here
function createGreeting(name) {
return "Hello, my name is " + name ;
}
var greeting = createGreeting("Daniel");
console.log(greeting);


// Declare your function first
function addNum(x,y) {
return x+y ;
}
// Call the function and assign to a variable `sum`
var sum = addNum(13,124);
console.log(sum);


function nameAge(name,age) {
return "Hello, my name is " + name + " and I'm " + age + " years old" ;
}
// Call the function
var greeting = nameAge("Daniel", 30);
console.log(greeting);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, be mindful of consistent formatting, otherwise, great work.

6 changes: 6 additions & 0 deletions exercises/K-functions-parameters/exercise2.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
// Declare your function first
function divide(x,y){

return x/y;
}



var result = divide(3, 4);

Expand Down
4 changes: 3 additions & 1 deletion exercises/K-functions-parameters/exercise3.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Write your function here

function createGreeting(name) {
return "Hello, my name is " + name ;
}
var greeting = createGreeting("Daniel");

console.log(greeting);
6 changes: 5 additions & 1 deletion exercises/K-functions-parameters/exercise4.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Declare your function first
function addNum(x,y) {
return x+y ;
}

// Call the function and assign to a variable `sum`
var sum = addNum(13,124);

console.log(sum);
console.log(sum);
6 changes: 5 additions & 1 deletion exercises/K-functions-parameters/exercise5.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Declare your function here
function addNum(name,age) {
return "Hello, my name is " + name + " and I'm " + age + " years old" ;
}

const greeting = createLongGreeting("Daniel", 30);
// Call the function
var greeting = createLongGreeting("Daniel", 30);

console.log(greeting);
16 changes: 16 additions & 0 deletions exercises/L-functions-nested/exercise.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,19 @@ var mentor2 = "Irina";
var mentor3 = "Mimi";
var mentor4 = "Rob";
var mentor5 = "Yohannes";

function hello(name) {
return "Hello " + name;
}

function createCreeting(name1, name2, name3, name4, name5) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, i think is better to use for loop

var message1 = hello(name1);
var message2 = hello(name2);
var message3 = hello(name3);
var message4 = hello(name4);
var message5 = hello(name5);
return message1 + message2 , message3, message4, message5;
}

var greeting = createCreeting(mentor1, mentor2, mentor3, mentor4, mentor5);
console.log(greeting);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check your logging to the console. I get "Hello Yohannes" printed to the console, have a look at your return statement from the function createGreeting()

8 changes: 4 additions & 4 deletions mandatory/1-syntax-errors.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a, b, c) {
return a + b + c;
}

function introduceMe(name, age)
return "Hello, my name is " + name "and I am " age + "years old";
return "Hello, my name is " + name + "and I am " + age + "years old";

@mike-shields-cyf mike-shields-cyf Jul 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be mindful of leading and trailing whitespace when concatenating strings, curly braces are also missing here.


function getTotal(a, b) {
total = a ++ b;
total = a + b;

return "The total is total";
return "The total is " + total;
}

/*
Expand Down
9 changes: 5 additions & 4 deletions mandatory/2-logic-error.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
// The syntax for this function is valid but it has an error, find it and fix it.

function trimWord(word) {
return wordtrim();
return word.trim();
}



function getStringLength(word) {
return "word".length();
return word.length();
}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;
}

/*
Expand Down
4 changes: 4 additions & 0 deletions mandatory/3-function-output.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
// Add comments to explain what this function does. You're meant to use Google!
// Returns a random number times by 10
function getRandomNumber() {
return Math.random() * 10;
}

// Add comments to explain what this function does. You're meant to use Google!
// count() function is used to count the number of collections in the element
function combine2Words(word1, word2) {
return word1.concat(word2);
}

function concatenate(firstWord, secondWord, thirdWord) {
return concat(firstWord, secondWord, thirdWord)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concat needs to be called as a method on a string. Also be aware of any neccesary whitespace. Please request access to the solutions repo and check your answer.


// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.
}
Expand Down
8 changes: 6 additions & 2 deletions mandatory/4-tax.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(price) {
return price * 1.20;
}

/*
CURRENCY FORMATTING
Expand All @@ -17,7 +19,9 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/

function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(new_price) {
return concat ("£" + float(new_price * 1.20))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some issues, here. Please request access to the solutions repo and check your answer. If there is something you don't understand, please let me know.

}

/*
===================================================
Expand Down