London10-Afsha-Hossain-HTML/CSS-Week1 - #598
Conversation
Replicated the web page
Corrected logo image location by removing an unnecessary dot.
| <div class="nav-item" id="nav-item1">Meet Karma</div> | ||
| <div class="nav-item" >How it Works</div> | ||
| <div class="nav-item" >Store</div> | ||
| <div class="nav-item" >Blog</div> |
There was a problem hiding this comment.
Hi Afsha i'm doing a code review to complete the homework :
What i would suggest is usig ul tag to group the navigation items, add aria-label attributes to the nav and ' a' tags to improve accessibility for screen readers, and used descriptive text for each navigation item.
Use appropriate HTML tags: The nav tag should be used to wrap the navigation links, and each navigation item should be an a tag with appropriate attributes.
Add href attributes to each navigation item to create clickable links.
Use descriptive text for each navigation item that conveys its purpose to users, and avoid using generic or ambiguous text.
Adding aria-label attributes to the nav and 'a' tags to improve accessibility for screen readers.
|
|
||
|
|
||
| .product-nav { | ||
| display: flex; |
There was a problem hiding this comment.
Hi Afsha, such great job you've done, may i suggest implementing the DRY principle of not repeating code, so you could group all your flex items together.
5 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The task took about 10 hours but I managed to complete it on my own.
What did you find hard?
Starting the task was the hardest for me.
What do you still not understand?
Any other notes?