Manchester Class 1 -Adiba Belayete - HTML/CSS- Week_01 - #445
Open
Adibab wants to merge 19 commits into
Open
Conversation
Doris-Siu
reviewed
Aug 12, 2022
Doris-Siu
left a comment
Doris-Siu
left a comment
There was a problem hiding this comment.
Overall nice codes, can use more semantic and descriptive tags.
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
||
| <main> |
There was a problem hiding this comment.
After tags, all your visible parts of the webpage should be put in "body" tags, and inside "body", it will be further divided into "header", "main" & "footer".
| <ul> | ||
| <li>Meet Karma</li> | ||
| <li> How it works</li> | ||
| <li onclick="run()" >Store</li> |
There was a problem hiding this comment.
A simpler way - you can add "a" tag inside each of your "li" item and then declare a href="" to a destination.
|
|
||
|
|
||
| <section class ="firstOne"> | ||
| <img id="background-image" src="img/first-background.jpg" alt="backgorund-image" style="width: 100%"> |
There was a problem hiding this comment.
Better put all your styling into the css file, it helps readiness.
| <section class ="firstOne"> | ||
| <img id="background-image" src="img/first-background.jpg" alt="backgorund-image" style="width: 100%"> | ||
| <article class="article"> | ||
| <p>Introducing Karma</p> |
There was a problem hiding this comment.
This one can use more descriptive tag - "h1".
| </section> | ||
|
|
||
| <section id="second-one-headline"> | ||
| <p> Everyone needs a little Karma </p> |
There was a problem hiding this comment.
This one can use more descriptive tag - "h2".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?