northwest4/declan-heritage - #199
Closed
Declanhs wants to merge 5 commits into
Closed
Conversation
background wont show :S
Just footer left to do and cleaning up responsiveness. (also need to covert svg files that should be fun!)
nax2uk
reviewed
Jun 21, 2021
Comment on lines
+58
to
+60
| button { | ||
| background-color: rgb(240, 128, 0); | ||
| } |
There was a problem hiding this comment.
Might want to add a padding property and a border-radius property to match the photo.
nax2uk
reviewed
Jun 21, 2021
Comment on lines
+28
to
+30
| .nav-item:hover { | ||
| color: orange; | ||
| } |
There was a problem hiding this comment.
Might want to add cursor: pointer; here to have a hand icon to match photo
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
not much
What did you find hard?
most of it
What do you still not understand?
flex
Any other notes?