london-class-7/ramla-jama - #143
Conversation
Behnazz
left a comment
Behnazz
left a comment
There was a problem hiding this comment.
This is a very good website. Welldone :) .
Your media query needs a bit more work.
Just some minor comments to improve it.
| order: 1; | ||
| } |
There was a problem hiding this comment.
| order: 1; | |
| } | |
| order: 1; | |
| margin-right: 120px; | |
| } |
|
|
||
| nav { | ||
| display: flex; | ||
| justify-content: space-around; |
There was a problem hiding this comment.
| justify-content: space-around; | |
| justify-content: space-between; |
|
|
||
| .nav-wrapper { | ||
| display: flex; | ||
| flex-direction :row; |
There was a problem hiding this comment.
by default flex direction is flex row
| flex-direction :row; |
| flex-wrap : nowrap; | ||
| justify-content:flex-end; | ||
| align-items:flex-start; | ||
| align-content:space-between; |
There was a problem hiding this comment.
| flex-wrap : nowrap; | |
| justify-content:flex-end; | |
| align-items:flex-start; | |
| align-content:space-between; | |
| flex-wrap : nowrap; | |
| justify-content:flex-end; | |
| align-items:flex-start; | |
| align-content:space-between; |
Do you need these? What will happen if we don't have them?
| padding: 25px; | ||
| background-size: cover; | ||
| background-repeat: no-repeat; | ||
| background-size: 90% 100%; |
There was a problem hiding this comment.
| background-size: 90% 100%; |
|
|
||
|
|
|
|
||
|
|
||
| </header> | ||
|
|
| </header> | ||
|
|
||
| <main> | ||
|
|
|
|
||
| <br> | ||
| <br> | ||
| <br> | ||
|
|
There was a problem hiding this comment.
| <br> | |
| <br> | |
| <br> |
It is not a good practice to have
to achieve a styling goal. It is better to use CSS to do the styling
| </section> | ||
| <p class= "copy-write">© Karma Mobility, Inc.</p> | ||
| </footer> | ||
|
|
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
| } | |
| } | |
| } | |
| .nav-wrapper { | |
| display: none; | |
| } | |
| nav { | |
| padding: 0; | |
| } | |
| #info { | |
| height: 60vh; | |
| } | |
| } |
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
2 participants
Your Details
Homework Details