Add numeric framerate limit input#3632
Open
Riqqqque wants to merge 3 commits intoCaffeineMC:devfrom
Open
Conversation
douira
requested changes
May 6, 2026
Contributor
douira
left a comment
douira
left a comment
There was a problem hiding this comment.
If you don't have a suggestion for changes to the API to accomodate a second type of integer option, I can also do that myself during merge.
douira
requested changes
May 7, 2026
Contributor
douira
left a comment
douira
left a comment
There was a problem hiding this comment.
I've pushed some changes to this branch to clean up some things, faster than going back and forth here.
- However, I've noticed that once I enter a number into the text field, it doesn't let me change it.
- Focusing it by keyboard navigation works, but it doesn't let me enter text
- In the video the reset button shows up sometimes, but that's just because pressing shift + tab activates it because of the shift key
- Clicking on the text field doesn't activate the cursor once it's been used
- When the text field is activated and there's an outline around the option, the outlines touch which is not nice
- The text in the textbox seems to be around 1-2 pixels too high and not vertically centered
output.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3556.
Adds a numeric input for the framerate limit so exact caps can be entered instead of being limited to 10 FPS slider steps.
Changes:
The standalone addon this was ported from is Unlicense.
Validation:
./gradlew.bat build./gradlew.bat :common:compileJava :fabric:compileJava :neoforge:compileJava --rerun-tasks