Support for Status Action and Events for PJSIP Registered endpoints#204
Support for Status Action and Events for PJSIP Registered endpoints#204VasuInukollu wants to merge 9 commits intoAsterNET:masterfrom
Conversation
…etail, AuthDetail, TransportDetail, IdentifyDetail etc.
merging incoming changes
|
The PR just adds placeholders/stubs for the event classes? Is the intention here to add properties to these? |
First thing, I was not sure if you would be keen to merge this. I didn't go through the half a dozen pull requests pending (as to why they are not merged) and assumed, you may not have time to review these. Idea was to get PJSIP to your attention. The current code base is already populating these response variables in the attributes field. Should we add the properties? Should be an easy job. |
Deantwo
left a comment
Deantwo
left a comment
There was a problem hiding this comment.
I see nothing wrong with the addition of the new events, but the classes don't have any properties and the new event handlers don't have any summary comments.
Other than that I mostly wonder why you are only adding PJSIPShowEndpointAction, shouldn't you also add PJSIPShowEndpointsAction?
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerAction_PJSIPShowEndpoints
| public TransportDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_TransportDetail
| public IdentifyDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_IdentifyDetail
| public EndpointDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_EndpointDetail
| public EndpointDetailCompleteEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_EndpointDetailComplete
| public ContactStatusDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_ContactStatusDetail
| public AuthDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_AuthDetail
| public AorDetailEvent(ManagerConnection source) | ||
| : base(source) | ||
| { | ||
| } |
There was a problem hiding this comment.
Could add some properties to this class.
Asterisk documentation has a list of the values.
See: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_AorDetail
| /// </summary> | ||
| public event EventHandler<QueueSummaryEvent> QueueSummary; | ||
|
|
||
| public event EventHandler<EndpointDetailEvent> EndpointDetail; |
There was a problem hiding this comment.
Summary comments on these would be nice.
You can just take the "Synopsis" part of the events from the Asterisk documentation, and a link to the documentation page.
For example: https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerEvent_EndpointDetail
| namespace AsterNET.Manager.Action | ||
| { | ||
| /// <seealso cref="Manager.Event.EndpointDetailCompleteEvent" /> | ||
| public class PJSIPShowEndpointAction : ManagerActionEvent |
There was a problem hiding this comment.
Also need summary comments for the class and its properties too.
|
You can look at the other classes for examples of how to write the summary comments. |
incoming changes
incoming changes
Pulling changes from AsterNET
Incoming changes
Head end changes
3 participants
PJSIP is the default channel driver in the latest versions of Asterisk. The current builds do not even load the chan_sip by default and the direction is very clear.
Support from PJSIP could be essential going forward. I am working on a project that is using chan_pjsip instead of chan_sip.