Skip to content

fix(bot/auto-thread): Set first filename as thread title when message content is empty#402

Merged
RhysSullivan merged 13 commits into
AnswerOverflow:mainfrom
JoltCode:autothread-image-title-naming
May 20, 2023
Merged

fix(bot/auto-thread): Set first filename as thread title when message content is empty#402
RhysSullivan merged 13 commits into
AnswerOverflow:mainfrom
JoltCode:autothread-image-title-naming

Conversation

@JoltCode
Copy link
Copy Markdown
Collaborator

@JoltCode JoltCode commented May 20, 2023

Description

  • Adds support for using attachments on the auto thread feature

Fixes #277 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • A test has been added to the auto-thread testing file

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2023 11:32am

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2023

@JoltCode is attempting to deploy a commit to the Answer Overflow Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added 🎆event Event that can occur on the discord bot 🤖bot Relates to the discord bot labels May 20, 2023
@JoltCode JoltCode requested a review from RhysSullivan May 20, 2023 10:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2023 •
edited
Loading

Codecov Report

Merging #402 (26666a7) into main (28dc9ea) will increase coverage by 70.07%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main     #402       +/-   ##
=========================================
+ Coverage      0   70.07%   +70.07%     
=========================================
  Files         0       73       +73     
  Lines         0     2413     +2413     
  Branches      0      608      +608     
=========================================
+ Hits          0     1691     +1691     
- Misses        0      649      +649     
- Partials      0       73       +73
Impacted Files Coverage Δ
...ps/discord-bot/src/listeners/events/auto-thread.ts 100.00% <100.00%> (ø)

... and 72 files with indirect coverage changes

RhysSullivan
RhysSullivan requested changes May 20, 2023
View reviewed changes
Comment thread apps/discord-bot/src/listeners/events/auto-thread.ts Outdated
@JoltCode JoltCode requested a review from RhysSullivan May 20, 2023 10:59
@RhysSullivan RhysSullivan merged commit 9499fe0 into AnswerOverflow:main May 20, 2023
@JoltCode JoltCode deleted the autothread-image-title-naming branch May 20, 2023 14:20
RhysSullivan pushed a commit that referenced this pull request Dec 20, 2025
@JoltCode
fix(bot/auto-thread): Set first filename as thread title when message…
989d876 
… content is empty (#402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RhysSullivan RhysSullivan RhysSullivan approved these changes

Assignees

No one assigned

Labels

🤖bot Relates to the discord bot 🎆event Event that can occur on the discord bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bot]: fix thread naming when only image is sent

2 participants

@JoltCode @RhysSullivan