Skip to content

fix(web): polyfill for old browsers#308

Merged
RhysSullivan merged 11 commits into
AnswerOverflow:mainfrom
JoltCode:array-at-polyfill
Mar 29, 2023
Merged

fix(web): polyfill for old browsers#308
RhysSullivan merged 11 commits into
AnswerOverflow:mainfrom
JoltCode:array-at-polyfill

Conversation

@JoltCode
Copy link
Copy Markdown
Collaborator

@JoltCode JoltCode commented Mar 28, 2023 •
edited
Loading

Description

Fixes a bug which is causing complete website failing on certain client devices

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

With help from a user who is experiencing the bug

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
answer-overflow ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 10:20AM (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 10:20AM (UTC)

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 28, 2023

@JoltCode is attempting to deploy a commit to the AnswerOverflow Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the 🖥️website Relates to the website label Mar 28, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #308 (8321074) into main (23cea61) will increase coverage by 84.52%.
The diff coverage is n/a.

❗ Current head 8321074 differs from pull request most recent head 6ccabbc. Consider uploading reports for the commit 6ccabbc to get more accurate results

@@            Coverage Diff            @@
##           main     #308       +/-   ##
=========================================
+ Coverage      0   84.52%   +84.52%     
=========================================
  Files         0      134      +134     
  Lines         0    11497    +11497     
  Branches      0     1531     +1531     
=========================================
+ Hits          0     9718     +9718     
- Misses        0     1523     +1523     
- Partials      0      256      +256

see 134 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

RhysSullivan
RhysSullivan reviewed Mar 29, 2023
View reviewed changes
Comment thread apps/main-site/src/pages/_app.tsx Outdated
@JoltCode JoltCode changed the title fix(web): Array.prototype.at pollyfill fix(web): string .at polyfill Mar 29, 2023
@JoltCode JoltCode marked this pull request as ready for review March 29, 2023 09:56
@JoltCode JoltCode requested a review from RhysSullivan March 29, 2023 09:56
@RhysSullivan RhysSullivan changed the title fix(web): string .at polyfill fix(web): polyfill for old browsers Mar 29, 2023
@RhysSullivan RhysSullivan merged commit e31e007 into AnswerOverflow:main Mar 29, 2023
@JoltCode JoltCode deleted the array-at-polyfill branch March 30, 2023 08:31
RhysSullivan pushed a commit that referenced this pull request Dec 20, 2025
@JoltCode
fix(web): polyfill for old browsers (#308)
8dbaa4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RhysSullivan RhysSullivan Awaiting requested review from RhysSullivan

Assignees

No one assigned

Labels

🖥️website Relates to the website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoltCode @RhysSullivan