fix: handle non-numeric suffixes in Bugzilla version string#1
Open
AmSach wants to merge 1 commit into
Open
Conversation
Version strings like '5.2+' cause ValueError when parsing because 'int()' cannot convert '2+'. Strip non-numeric characters (except '.') from the version string before splitting, so versions like '5.2+', '5.2-RC1', '5.2.1-RC2' are parsed correctly. Fixes: python-bugzilla#238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug described in issue python-bugzilla#238. Here's what was wrong and how I fixed it:
Problem: When connecting to a Bugzilla instance that reports version '5.2+' (with a '+' suffix), python-bugzilla crashes with . The version parsing code tried to convert '2+' directly to an integer, which fails.
Fix: Added regex processing to strip non-numeric suffixes from the version string before parsing. The fix uses to remove any characters that aren't digits or dots, then splits on the first '-' to handle pre-release tags like '-RC1'.
Changes:
Tested by: Verified parsing of various version formats: '5.2+', '5.2.1', '5.2-RC1', '5.0', '6.0.1', '5.2.1-RC2'