This repository was archived by the owner on Sep 7, 2025. It is now read-only.
Add lucky numbers#32
Closed
richardhozak wants to merge 1 commit into
Closed
Conversation
Member
|
Hi @Zxey I liked, but it seems that the algorithm isn't properly implemented.
From 1-100 the lucky numbers should be: This is the link to your implementation repl.it/@abranhe/lucky-numbers-in-python online, I just set the range from 1 - 100. In a part of the output you will see: Where they don't match with the output it should be: Eg:
So this need to be fixed to be merged, I am creating an issue right now, hopefuly we will implement correctly. |
abranhe
suggested changes
Oct 4, 2018
Member
abranhe
left a comment
There was a problem hiding this comment.
Needs changes see #32 (comment)
This was referenced Oct 4, 2018
a50cf03 to
6b01418
Compare
Author
|
Fixed lucky numbers implementation as per AllAlgorithms/cpp#83 implementation. |
6b01418 to
a0c9b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds lucky numbers implementation based on https://github.com/abranhe/algorithms/tree/master/math/lucky-numbers