Skip to content
This repository was archived by the owner on Sep 7, 2025. It is now read-only.

Add factorial with docs#23

Merged
abranhe merged 2 commits into
AllAlgorithms:masterfrom
0xp4blo:add-factorial
Oct 2, 2018
Merged

Add factorial with docs#23
abranhe merged 2 commits into
AllAlgorithms:masterfrom
0xp4blo:add-factorial

Conversation

@0xp4blo
Copy link
Copy Markdown
Contributor

@0xp4blo 0xp4blo commented Oct 2, 2018

Hacktoberfest 🎃! #6

@abranhe
Copy link
Copy Markdown
Member

abranhe commented Oct 2, 2018

Thank you for contributing to Algorithms/cpp, we are happy to merge your pull request but first, it needs to fix:

Can you please:

  • move the algorithm directly into /math and remove a folder for it!
  • all docs for algorithms should be added to AllAlgorithms/algorithms (you should open a pull request there ;))

we are waiting for your changes

Comment thread math/Factorial/README.md Outdated
@@ -0,0 +1,5 @@
# Factorial
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this docs

@@ -0,0 +1,24 @@
/* Factorial
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move factorial.cpp to the /math directory

@0xp4blo
Copy link
Copy Markdown
Contributor Author

0xp4blo commented Oct 2, 2018

Done 🎃

@abranhe
Copy link
Copy Markdown
Member

abranhe commented Oct 2, 2018

Thank you again for contributing to Algorithms/cpp, your pr got merged! ✨

@abranhe abranhe merged commit 527a00a into AllAlgorithms:master Oct 2, 2018
@0xp4blo 0xp4blo deleted the add-factorial branch October 2, 2018 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants