Fix crashing source code loader example#11
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: 0-coding <0-coding@users.noreply.github.com>
Co-authored-by: 0-coding <0-coding@users.noreply.github.com>
Co-authored-by: 0-coding <0-coding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The recently added
source/load_mod_from_source_code.pyexample crashed on every execution because the dynamically executed snippet referenced an undefined name. Any user running the example hit aNameErrorinstead of seeing the intended loaded value.Root cause
The script executed
a=binside an otherwise empty namespace, sobwas unresolved duringexec.Fix
Changed the snippet to assign the literal string value (
a='b') and added a standard-library unittest regression test that executes the script as a subprocess.Validation
python3 source/load_mod_from_source_code.pypython3 -m unittest discover -s tests -v