Delete temporary element after use

starseeker · cshorler · commit a6bea3572ec9 · 2022-06-11T20:14:25.000+01:00
diff --git a/src/clstepcore/Registry.cc b/src/clstepcore/Registry.cc
@@ -235,13 +235,13 @@ void Registry::RemoveType( const char * n ) {
  */
 void Registry::RemoveClones( const EntityDescriptor & e ) {
     const SchRename * alts = e.AltNameList();
-    struct Element * tmp;
 
     while( alts ) {
-        tmp = new Element;
+        struct Element * tmp = new Element;
         tmp->key = ( char * ) alts->objName();
         SC_HASHsearch( primordialSwamp, tmp, HASH_DELETE );
         alts = alts->next;
+	delete tmp;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -235,13 +235,13 @@ void Registry::RemoveType( const char * n ) {`
`235`	`235`	`*/`
`236`	`236`	`void Registry::RemoveClones( const EntityDescriptor & e ) {`
`237`	`237`	`const SchRename * alts = e.AltNameList();`
`238`		`- struct Element * tmp;`
`239`	`238`
`240`	`239`	`while( alts ) {`
`241`		`- tmp = new Element;`
	`240`	`+ struct Element * tmp = new Element;`
`242`	`241`	`tmp->key = ( char * ) alts->objName();`
`243`	`242`	`SC_HASHsearch( primordialSwamp, tmp, HASH_DELETE );`
`244`	`243`	`alts = alts->next;`
	`244`	`+ delete tmp;`
`245`	`245`	`}`
`246`	`246`	`}`
`247`	`247`