sync-pr-commit-title, pr-first-commit-title - Don't omit backticks (#9012)

SunsetTechuila · web-flow · commit a6d74ca8f194 · 2026-03-03T12:06:45.000+08:00
diff --git a/source/features/pr-first-commit-title.tsx b/source/features/pr-first-commit-title.tsx
@@ -6,33 +6,17 @@ import {insertTextIntoField, setFieldText} from 'text-field-edit';
 import features from '../feature-manager.js';
 import looseParseInt from '../helpers/loose-parse-int.js';
 import observe from '../helpers/selector-observer.js';
-
-function interpretNode(node: ChildNode): string | void {
-	switch (node instanceof Element && node.tagName) {
-		case false:
-		case 'A': {
-			return node.textContent;
-		}
-
-		case 'CODE': {
-			// Restore backticks that GitHub loses when rendering them
-			return '`' + node.textContent + '`';
-		}
-
-		default:
-			// Ignore other nodes, like `<span>...</span>` that appears when commits have a body
-	}
-}
+import parseRenderedText from '../github-helpers/parse-rendered-text.js';
 
 function getFirstCommit(firstCommit: HTMLElement): {title: string; body: string | undefined} {
 	const body = $optional('.Details-content--hidden pre', firstCommit)
 		?.textContent
 		.trim() ?? undefined;
 
-	const title = [...firstCommit.childNodes]
-		.map(node => interpretNode(node))
-		.join('')
-		.trim();
+	const title = parseRenderedText(firstCommit.firstElementChild!, ({nodeName}) =>
+		// Exclude expand body button
+		nodeName === '#text' || nodeName === 'CODE' ? NodeFilter.FILTER_ACCEPT : NodeFilter.FILTER_REJECT,
+	);
 
 	return {title, body};
 }
@@ -89,8 +73,14 @@ void features.add(import.meta.url, {
 });
 
 /*
+
 Test URLs
 
-Few commit: https://github.com/refined-github/sandbox/compare/rendered-commit-title?expand=1
-Many commits: https://github.com/refined-github/refined-github/compare/refined-github:refined-github:esbuild-2...pgimalac:refined-github:pgimalac/fit-rendered-markdown?expand=1
+Few commits:
+	- https://github.com/refined-github/sandbox/compare/rendered-commit-title?expand=1
+	- https://github.com/refined-github/sandbox/compare/9012?expand=1
+Many commits:
+	- https://github.com/refined-github/refined-github/compare/refined-github:refined-github:esbuild-2...pgimalac:refined-github:pgimalac/fit-rendered-markdown?expand=1
+	- https://github.com/refined-github/sandbox/compare/9012-2?expand=1
+
 */
diff --git a/source/features/sync-pr-commit-title.tsx b/source/features/sync-pr-commit-title.tsx
@@ -11,6 +11,7 @@ import observe from '../helpers/selector-observer.js';
 import cleanPrCommitTitle from '../helpers/pr-commit-cleaner.js';
 import setReactInputValue from '../helpers/set-react-input-value.js';
 import {confirmMergeButton} from '../github-helpers/selectors.js';
+import parseRenderedText from '../github-helpers/parse-rendered-text.js';
 
 const commitTitleFieldSelector = '[data-testid="mergebox-partial"] input';
 
@@ -33,7 +34,7 @@ function createCommitTitle(): string {
 		// Old view - TODO: Remove after July 2026
 		'input#issue_title',
 	]);
-	const prTitleText = (prTitle instanceof HTMLInputElement ? prTitle.value : prTitle.textContent).trim();
+	const prTitleText = prTitle instanceof HTMLInputElement ? prTitle.value.trim() : parseRenderedText(prTitle);
 	return formatPrCommitTitle(prTitleText);
 }
 
diff --git a/source/github-helpers/parse-rendered-text.ts b/source/github-helpers/parse-rendered-text.ts
@@ -0,0 +1,37 @@
+export default function parseRenderedText(element: Element, filter?: NodeFilter): string {
+	const walker = document.createTreeWalker(element, NodeFilter.SHOW_ALL, filter);
+
+	// eslint-disable-next-line @typescript-eslint/no-restricted-types
+	let currentNode = walker.currentNode as Node | null;
+	let parsedText = '';
+
+	while (currentNode) {
+		if (currentNode.nodeName === 'CODE') {
+			const {textContent} = currentNode;
+			// Restore backticks that GitHub loses when rendering them
+			parsedText += `\`${textContent?.trim()}\``;
+
+			// Skip the children
+			currentNode = walker.nextSibling();
+			while (!currentNode) {
+				currentNode = walker.parentNode();
+
+				if (currentNode === walker.root) {
+					return parsedText.trim();
+				}
+
+				currentNode = walker.nextSibling();
+			}
+
+			continue;
+		}
+
+		if (currentNode.nodeType === Node.TEXT_NODE) {
+			parsedText += currentNode.nodeValue;
+		}
+
+		currentNode = walker.nextNode();
+	}
+
+	return parsedText.trim();
+}
