finalise before onSpoolStop signal send#899
Merged
David-Baddeley merged 1 commit intoMar 1, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
- Coverage 11.30% 11.30% -0.01%
==========================================
Files 624 624
Lines 71803 71803
==========================================
- Hits 8117 8114 -3
- Misses 63686 63689 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue TODO, #898, kinda related to #850 and #857
we either need to 1) swap finalise and onSpoolStop signal, b) add another signal to say when we're really really done and can e.g. hook recipe pushing, or c) rules would handle for themselves in the pushing whether they're ready to start or waiting on a file to arrive.
c is ideal, but for recipes its a bit harder than for localization where we've already got it. I'm suggesting we do option a) now and c) when we can
Is this a bugfix or an enhancement?
robustness improvement
Proposed changes:
Checklist:
much simpler if this is kept separate from functional changes]
If an enhancement (or non-trivial bugfix):