Skip to content

finalise before onSpoolStop signal send#899

Merged
David-Baddeley merged 1 commit into
python-microscopy:masterfrom
barentine:spoolstopsignal
Mar 1, 2021
Merged

finalise before onSpoolStop signal send#899
David-Baddeley merged 1 commit into
python-microscopy:masterfrom
barentine:spoolstopsignal

Conversation

@barentine
Copy link
Copy Markdown
Member

Addresses issue TODO, #898, kinda related to #850 and #857
we either need to 1) swap finalise and onSpoolStop signal, b) add another signal to say when we're really really done and can e.g. hook recipe pushing, or c) rules would handle for themselves in the pushing whether they're ready to start or waiting on a file to arrive.

c is ideal, but for recipes its a bit harder than for localization where we've already got it. I'm suggesting we do option a) now and c) when we can

Is this a bugfix or an enhancement?
robustness improvement
Proposed changes:

  • swap finalise and onSpoolStop send

Checklist:

  • Tested with numpy=1.14
  • Tested on python 2.7 and 3.6
  • Tested with wx=3.x and wx=4.x [if UI code]
  • Does the PR avoid variable renaming in existing code, whitespace changes, and other forms of tidying? [There is a place for code tidying, but it makes reviewing
    much simpler if this is kept separate from functional changes]

If an enhancement (or non-trivial bugfix):

  • Has this been discussed in advance (feature request, PR proposal, email, or direct conversation)?
  • Does this change how users interact with the software? How will these changes be communicated?
  • Does this maintain backwards compatibility with old data?
  • Does this change the required dependencies?
  • Are there any other side effects of the change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2021

Codecov Report

Merging #899 (9f98d2a) into master (5165d2d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   11.30%   11.30%   -0.01%     
==========================================
  Files         624      624              
  Lines       71803    71803              
==========================================
- Hits         8117     8114       -3     
- Misses      63686    63689       +3     
Impacted Files Coverage Δ
PYME/Acquire/Spooler.py 71.42% <100.00%> (ø)
PYME/localization/FitFactories/InterpFitR.py 78.18% <0.00%> (-2.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5165d2d...9f98d2a. Read the comment docs.

@David-Baddeley David-Baddeley merged commit ff76c37 into python-microscopy:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants