hardware support for micro photon devices picosecond delayer#1232
Merged
Conversation
Contributor
|
Will merge as is ... but probably need to think a bit more about the conventions for new hardware going forward. As much as there is a current convention it is to use functional setters/getters rather than attribute/property access for hardware parameters that you might change. A lot of this is historical, and in some respects property-based access is more "pythonic", but there is definitely a case for being consistent across different hardware types. The potential arguments for functional getters/setters are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a bugfix or an enhancement?
enhancement
Proposed changes:
Note: will likely follow up at some point with a class to support the Picoquant Taiko pulsed/cw driver.
Checklist:
much simpler if this is kept separate from functional changes]
If an enhancement (or non-trivial bugfix):