This repository was archived by the owner on Apr 15, 2024. It is now read-only.
This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Environment variables should not have precedence over Consul constructor arguments #192
The token passed in as an argument in the constructor is overriden by the
CONSUL_HTTP_TOKEN(if set): https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul/base.py#L311The same is true with the host and port (and others!):
https://github.com/cablehead/python-consul/blob/d056ff5c4efc6a5642775ad66600864e3f0f6cbc/consul/base.py#L297-L299
I would argue that this is not the behaviour most would expect. It would be better if the precedence order was
argument > env > default.