gh-120713: normalize year with century for datetime.strftime#120820
Merged
serhiy-storchaka merged 56 commits intopython:mainfrom Jun 29, 2024
Merged
gh-120713: normalize year with century for datetime.strftime#120820serhiy-storchaka merged 56 commits intopython:mainfrom
serhiy-storchaka merged 56 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms such as Linux,
datetime.strftimedoes not 0-pad a year <= 999 when formatting with'%Y'despite the documentation claiming an example output of "0001, 0002, …". The same issue applies when formatting with"%G".This PR fixes the issue by formatting a year with century with
'%04ld'usingsprintf(in C) or'{:04}'usingstr.format(in Python) if the platform is found to show the aforementioned behavior.datetime.strftime("%Y")is not padding correctly #120713