gh-100762: Fix optimization in gen_close #111069
Merged
iritkatriel merged 6 commits intopython:mainfrom Oct 25, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In f02fa64 lines 383-389 were added, with returns that do not decref
yf. I think this is ok becauseyfis always NULL in these cases. Adding the assertions.Also, the optimization for the case of exception_handler_depth== 1 is not working because
op.codeis checked instead ofop.arg.