Conversation
Member
|
You can also refer to #2219 which I have recently rebased |
Member
Author
Thanks for the link to prior art 🙌 , I wanted to attempt an all or nothing change and see what actually needs to change 🤔 |
Member
|
One idea I had, was to convert things like, let's say: %x{
for (i = 0; i < 100; i++) {
...to: %x{
for (i = 0; i < #{100}; i++) {
...so that perhaps we could think of some way to make this an optional change. But that all depends on if the performance impact is noticeable. |
elia
force-pushed
the
elia/bigint-integers
branch
from
0a8ed4d to
eb87c06
Compare
The new bin/test should accept any test file within the project and understand how to run it even if the test/ or spec/ prefix is missing. E.g. bin/test spec/lib/builder_processors_spec.rb # RSpec bin/test spec/ruby/library/time/to_time_spec.rb # MSpec: Ruby Spec bin/test spec/opal/core/array/compact_spec.rb # MSpec: Opal bin/test test/opal/test_base64.rb # Minitest
elia
force-pushed
the
elia/bigint-integers
branch
from
eb87c06 to
aaa4623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.