Don't create a new ParserImpl on each parser() call (#11255)

normanmaurer · normanmaurer · commit 605290f82102 · 2021-05-14T15:33:19.000+02:00
Motivation:

ParserImpl is stateless and so we can use the same instance multiple times

Modifications:

- Make constructor private
- Return the same instance all the time

Result:

Less object creation
diff --git a/resolver/src/main/java/io/netty/resolver/HostsFileEntriesProvider.java b/resolver/src/main/java/io/netty/resolver/HostsFileEntriesProvider.java
@@ -120,7 +120,7 @@ public interface Parser {
      * @return a new {@link HostsFileEntriesProvider.Parser}
      */
     public static Parser parser() {
-        return new ParserImpl();
+        return ParserImpl.INSTANCE;
     }
 
     static final HostsFileEntriesProvider EMPTY =
@@ -164,6 +164,12 @@ private static final class ParserImpl implements Parser {
 
         private static final InternalLogger logger = InternalLoggerFactory.getInstance(Parser.class);
 
+        static final ParserImpl INSTANCE = new ParserImpl();
+
+        private ParserImpl() {
+            // singleton
+        }
+
         @Override
         public HostsFileEntriesProvider parse() throws IOException {
             return parse(locateHostsFile(), Charset.defaultCharset());
