Check if its same buildinfo only for directly referenced projects and not recursively - #50617
Merged
Merged
Conversation
… not recursively Fixes #50545
ghost
self-assigned this
ghost
added
Author: Team
For Uncommitted Bug
ghost
requested review from
Andrew Casey (amcasey) and
Andrew Branch (andrewbranch)
September 2, 2022 19:42
commented
Sep 2, 2022
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.8 |
|
Heya Sheetal Nandi (@sheetalkamat), I've started to run the task to cherry-pick this into |
ghost
mentioned this pull request
commented
Sep 2, 2022
|
Hey Sheetal Nandi (@sheetalkamat), I've opened #50618 for you. |
Andrew Branch (andrewbranch)
approved these changes
Sep 2, 2022
Jake Bailey (jakebailey)
approved these changes
Sep 2, 2022
ghost
deleted the
hasSameBuildInfo
branch
September 2, 2022 20:38
ghost
mentioned this pull request
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thats because we issue errors only for direct references and not indirect references when creating program so no need to check recursively for uptodate-ness check either.
Fixes #50545