Simplify compile-time evaluation logic

kmr-srbh · kmr-srbh · commit e5153819938d · 2024-04-27T10:38:08.000+05:30
diff --git a/src/libasr/pass/intrinsic_functions.h b/src/libasr/pass/intrinsic_functions.h
@@ -4677,14 +4677,17 @@ static inline ASR::expr_t *eval_list_pop(Allocator &/*al*/,
             return nullptr;
         }
         ASR::ListConstant_t* clist = ASR::down_cast<ASR::ListConstant_t>(args[0]);
+        int64_t index;
 
         if (args.n == 1) {
-            return clist->m_args[clist->n_args - 1];
+            index = clist->n_args - 1;
+            return clist->m_args[index];
         } else {
             if (args[1] == nullptr) {
                 return nullptr;
             }
-            return clist->m_args[ASR::down_cast<ASR::IntegerConstant_t>(ASRUtils::expr_value(args[1]))->m_n];
+            index = ASR::down_cast<ASR::IntegerConstant_t>(ASRUtils::expr_value(args[1]))->m_n;
+            return clist->m_args[index];
         }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -4677,14 +4677,17 @@ static inline ASR::expr_t eval_list_pop(Allocator &/al*/,`
`4677`	`4677`	`return nullptr;`
`4678`	`4678`	`}`
`4679`	`4679`	`ASR::ListConstant_t* clist = ASR::down_cast<ASR::ListConstant_t>(args[0]);`
	`4680`	`+ int64_t index;`
`4680`	`4681`
`4681`	`4682`	`if (args.n == 1) {`
`4682`		`- return clist->m_args[clist->n_args - 1];`
	`4683`	`+ index = clist->n_args - 1;`
	`4684`	`+ return clist->m_args[index];`
`4683`	`4685`	`} else {`
`4684`	`4686`	`if (args[1] == nullptr) {`
`4685`	`4687`	`return nullptr;`
`4686`	`4688`	`}`
`4687`		`- return clist->m_args[ASR::down_cast<ASR::IntegerConstant_t>(ASRUtils::expr_value(args[1]))->m_n];`
	`4689`	`+ index = ASR::down_cast<ASR::IntegerConstant_t>(ASRUtils::expr_value(args[1]))->m_n;`
	`4690`	`+ return clist->m_args[index];`
`4688`	`4691`	`}`
`4689`	`4692`
`4690`	`4693`	`}`