checkpatch: warn when declaring "struct spinlock foo;"

JoePerches · torvalds · commit 88982fea52d0 · 2012-12-17T17:15:19.000-08:00
spinlock_t should always be used.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Acked-by: "Luis R. Rodriguez" &lt;mcgrof@do-not-panic.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -3336,6 +3336,12 @@ sub process {
 			     "Avoid line continuations in quoted strings\n" . $herecurr);
 		}
 
+# check for struct spinlock declarations
+		if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
+			WARN("USE_SPINLOCK_T",
+			     "struct spinlock should be spinlock_t\n" . $herecurr);
+		}
+
 # Check for misused memsets
 		if ($^V && $^V ge 5.10.0 &&
 		    defined $stat &&
