From e64a4495f867de9fb854f040cee50132767c9ada Mon Sep 17 00:00:00 2001 From: kushalkolar Date: Wed, 22 Oct 2025 22:35:12 -0400 Subject: [PATCH 1/4] fix docstring --- fastplotlib/graphics/scatter.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fastplotlib/graphics/scatter.py b/fastplotlib/graphics/scatter.py index 4df4f7557..a2e696a82 100644 --- a/fastplotlib/graphics/scatter.py +++ b/fastplotlib/graphics/scatter.py @@ -101,8 +101,7 @@ def __init__( * Matplotlib compatible characters: "osD+x^v<>*". * Unicode symbols: "●○■♦♥♠♣✳▲▼◀▶". * Emojis: "❤️♠️♣️♦️💎💍✳️📍". - * A string containing the value "custom". In this case, the WGSL - code defined by ``custom_sdf`` will be used. + * A string containing the value "custom". In this case, WGSL code defined by ``custom_sdf`` will be used. uniform_marker: bool, default False Use the same marker for all points. Only valid when `mode` is "markers". Useful if you need to use From 6a1cc6d997eed5c8337b1af4f57c2a88b0c920bd Mon Sep 17 00:00:00 2001 From: kushalkolar Date: Wed, 22 Oct 2025 22:35:24 -0400 Subject: [PATCH 2/4] fix docstring --- fastplotlib/layouts/_graphic_methods_mixin.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fastplotlib/layouts/_graphic_methods_mixin.py b/fastplotlib/layouts/_graphic_methods_mixin.py index 62f824227..a38eaa8eb 100644 --- a/fastplotlib/layouts/_graphic_methods_mixin.py +++ b/fastplotlib/layouts/_graphic_methods_mixin.py @@ -497,11 +497,10 @@ def add_scatter( Supported values: * A string from pygfx.MarkerShape enum - * Matplotlib compatible characters: "osD+x^v<>". + * Matplotlib compatible characters: "osD+x^v<>*". * Unicode symbols: "●○■♦♥♠♣✳▲▼◀▶". * Emojis: "❤️♠️♣️♦️💎💍✳️📍". - * A string containing the value "custom". In this case, the WGSL - code defined by ``custom_sdf`` will be used. + * A string containing the value "custom". In this case, WGSL code defined by ``custom_sdf`` will be used. uniform_marker: bool, default False Use the same marker for all points. Only valid when `mode` is "markers". Useful if you need to use From 63e10896baa299690edc622e2720a5da415da093 Mon Sep 17 00:00:00 2001 From: kushalkolar Date: Wed, 22 Oct 2025 22:35:47 -0400 Subject: [PATCH 3/4] add docs _gallery to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c599d5f8c..bea3faf0d 100644 --- a/.gitignore +++ b/.gitignore @@ -135,3 +135,4 @@ dmypy.json .vscode/ examples/desktop/diffs/*.png +docs/source/_gallery/ From d43f083babdb7c2eada227deb7bdafd494988411 Mon Sep 17 00:00:00 2001 From: kushalkolar Date: Wed, 22 Oct 2025 23:05:39 -0400 Subject: [PATCH 4/4] no edge color for spinning spiral example --- examples/scatter/spinning_spiral.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/scatter/spinning_spiral.py b/examples/scatter/spinning_spiral.py index 80e893301..89e74eaec 100644 --- a/examples/scatter/spinning_spiral.py +++ b/examples/scatter/spinning_spiral.py @@ -34,7 +34,7 @@ canvas_kwargs={"max_fps": 500, "vsync": False} ) -spiral = figure[0, 0].add_scatter(data, cmap="viridis_r", alpha=0.5, sizes=sizes) +spiral = figure[0, 0].add_scatter(data, cmap="viridis_r", edge_colors=None, alpha=0.5, sizes=sizes) # pre-generate normally distributed data to jitter the points before each render jitter = np.random.normal(scale=0.001, size=n * 3).reshape((n, 3))