Skip to content

code structure? #95

Description

@amitwer

Hi,
When looking over the code I noticed that there is one huge file with all the assertions, and its quite difficult to find my way in it.
So, before I try to sort things and open a PR, is there a reason not to break it down to multiple classes? Since the user is only creating AssertionBuilder through the factory methods, it seems possible to either have Assertion inherit methods from a bunch of helper classes (FileAssertions, CollectionsAssertions, NumberASsertions etc.) or to initialize it with members that contain the implementation, so that the actual class will only have thin wrapper functions.

example:

def is_subset_of(val):
    self._collection_assertions.is_subset_of(val)
    return self

Metadata

Metadata

Assignees

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions