fix production build - issue #1644#1662
Closed
abner wants to merge 2 commits into
Closed
Conversation
…es: true } to fix production builds issue - see angular#1644 This fixes issue [https://github.com/angular/angular-cli/issues/1644](https://github.com/angular/angular-cli/issues/1644)
Contributor
Author
|
as we can see in this pull request, this is even the way on angular own build. https://github.com/angular/angular/pull/7988/files |
Member
Contributor
|
Yes this is what's needed to fix the issue. We can revert it once we support offline compiler |
Contributor
Author
|
ok @TheLarkInn. just did it. |
Member
|
@abner still looks like this branch is out of date with latest master. |
Contributor
|
@TheLarkInn @abner I'm updating it myself, no worries. |
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed mangle configuration to mangle: { screw_ie8 : true, keep_fnames: true } to fix production builds issue - see #1644