Enable derive guards for AsMapping/AsSequence slot methods

moreal · claude · moreal · commit bc8dc5d93628 · 2026-03-16T14:29:00.000+09:00
Remove redundant #[pymethod(name = "__len__")] from PyStr
(already provided via AsMapping/AsSequence trait impls).

Enable compile-time guards for __len__, __contains__, __getitem__,
__setitem__, __delitem__ to prevent future direct definitions.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/crates/derive-impl/src/pyclass.rs b/crates/derive-impl/src/pyclass.rs
@@ -981,12 +981,12 @@ where
                 ("__index__", "AsNumber"),
                 ("__bool__", "AsNumber"),
                 // AsSequence trait
-                // ("__len__", "AsSequence (or AsMapping)"),
-                // ("__contains__", "AsSequence"),
+                ("__len__", "AsSequence (or AsMapping)"),
+                ("__contains__", "AsSequence"),
                 // AsMapping trait
-                // ("__getitem__", "AsMapping (or AsSequence)"),
-                // ("__setitem__", "AsMapping (or AsSequence)"),
-                // ("__delitem__", "AsMapping (or AsSequence)"),
+                ("__getitem__", "AsMapping (or AsSequence)"),
+                ("__setitem__", "AsMapping (or AsSequence)"),
+                ("__delitem__", "AsMapping (or AsSequence)"),
                 // Iterable/IterNext traits
                 ("__iter__", "Iterable"),
                 ("__next__", "IterNext"),
diff --git a/crates/vm/src/builtins/str.rs b/crates/vm/src/builtins/str.rs
@@ -663,7 +663,6 @@ impl PyStr {
         self.data.is_empty()
     }
 
-    #[pymethod(name = "__len__")]
     #[inline]
     pub fn char_len(&self) -> usize {
         self.data.char_len()

Original file line number	Diff line number	Diff line change
`@@ -663,7 +663,6 @@ impl PyStr {`
`663`	`663`	`self.data.is_empty()`
`664`	`664`	`}`
`665`	`665`
`666`		`- #[pymethod(name = "__len__")]`
`667`	`666`	`#[inline]`
`668`	`667`	`pub fn char_len(&self) -> usize {`
`669`	`668`	`self.data.char_len()`