Return hash of e-mail in else clause

kevinsawicki · kevinsawicki · commit 795c936fb8b0 · 2012-09-10T10:28:07.000-07:00
GravatarUtils guards against an empty string so the
check does not need to be duplicated in AvatarLoader
diff --git a/app/src/main/java/com/github/mobile/util/AvatarLoader.java b/app/src/main/java/com/github/mobile/util/AvatarLoader.java
@@ -327,12 +327,8 @@ private String getId(final User user) {
         String gravatarId = user.getGravatarId();
         if (!TextUtils.isEmpty(gravatarId))
             return gravatarId;
-
-        String email = user.getEmail();
-        if (!TextUtils.isEmpty(email))
-            return GravatarUtils.getHash(email);
-
-        return null;
+        else
+            return GravatarUtils.getHash(user.getEmail());
     }
 
     /**
