🚑 2.4 优化与Bug修复

elunez · elunez · commit 3e500eed7dc1 · 2020-01-07T12:56:48.000+08:00
1、修复新增时 loading 失效的问题 #66
2、修复菜单图标为空时，表格渲染报错的问题 #65
3、修复新增详情时字典值不填报错的问题 #64
4、修复切换主题颜色时 header 操作按钮 margin-left 不正常的错误
5、修复切换主题颜色时日期搜索框宽度不正常的问题
6、编辑按钮加入 loading，避免重复提交
diff --git a/src/assets/styles/eladmin.scss b/src/assets/styles/eladmin.scss
@@ -3,12 +3,15 @@
   .filter-item {
     display: inline-block;
     vertical-align: middle;
-    margin: 0 2px 10px 0;
+    margin: 0 3px 10px 0;
     input {
       height: 30.5px;
       line-height: 30.5px;
     }
   }
+  .el-button+.el-button {
+    margin-left: 0 !important;
+  }
   .el-select__caret.el-input__icon.el-icon-arrow-up{
     line-height: 30.5px;
   }
@@ -17,7 +20,7 @@
     vertical-align: middle;
     margin-bottom: 10px;
     height: 30.5px;
-    width: 223px;
+    width: 223px !important;
   }
 }
 .el-avatar {
diff --git a/src/components/Crud/UD.operation.vue b/src/components/Crud/UD.operation.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <el-button v-permission="permission.edit" :disabled="disabledEdit" size="mini" type="primary" icon="el-icon-edit" @click="crud.toEdit(data)" />
+    <el-button v-permission="permission.edit" :loading="crud.status.cu === 2" :disabled="disabledEdit" size="mini" type="primary" icon="el-icon-edit" @click="crud.toEdit(data)" />
     <el-popover v-model="pop" v-permission="permission.del" placement="top" width="180" trigger="manual" @show="onPopoverShow" @hide="onPopoverHide">
       <p>{{ msg }}</p>
       <div style="text-align: right; margin: 0">
diff --git a/src/components/Crud/crud.js b/src/components/Crud/crud.js
@@ -244,13 +244,15 @@ function CRUD(options) {
       if (!callVmHook(crud, CRUD.HOOK.beforeSubmit)) {
         return
       }
+      crud.status.add = CRUD.STATUS.PROCESSING
       crud.crudMethod.add(crud.form).then(() => {
         crud.status.add = CRUD.STATUS.NORMAL
         crud.resetForm()
         crud.addSuccessNotify()
         callVmHook(crud, CRUD.HOOK.afterSubmit)
         crud.toQuery()
       }).catch(() => {
+        crud.status.add = CRUD.STATUS.PREPARED
         callVmHook(crud, CRUD.HOOK.afterAddError)
       })
     },
@@ -261,6 +263,7 @@ function CRUD(options) {
       if (!callVmHook(crud, CRUD.HOOK.beforeSubmit)) {
         return
       }
+      crud.status.edit = CRUD.STATUS.PROCESSING
       crud.crudMethod.edit(crud.form).then(() => {
         crud.status.edit = CRUD.STATUS.NORMAL
         crud.getDataStatus(crud.form.id).edit = CRUD.STATUS.NORMAL
@@ -269,6 +272,7 @@ function CRUD(options) {
         callVmHook(crud, CRUD.HOOK.afterSubmit)
         crud.refresh()
       }).catch(() => {
+        crud.status.edit = CRUD.STATUS.PREPARED
         callVmHook(crud, CRUD.HOOK.afterEditError)
       })
     },
diff --git a/src/components/ThemePicker/index.vue b/src/components/ThemePicker/index.vue
@@ -35,7 +35,6 @@ export default {
       if (typeof val !== 'string') return
       const themeCluster = this.getThemeCluster(val.replace('#', ''))
       const originalCluster = this.getThemeCluster(oldVal.replace('#', ''))
-      console.log(themeCluster, originalCluster)
 
       const $message = this.$message({
         message: ' Compiling the theme',
diff --git a/src/views/mnt/app/index.vue b/src/views/mnt/app/index.vue
@@ -58,7 +58,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/mnt/database/index.vue b/src/views/mnt/database/index.vue
@@ -52,7 +52,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/mnt/deploy/index.vue b/src/views/mnt/deploy/index.vue
@@ -89,7 +89,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--统还原组件-->
diff --git a/src/views/mnt/server/index.vue b/src/views/mnt/server/index.vue
@@ -42,7 +42,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/monitor/server/index.vue b/src/views/monitor/server/index.vue
@@ -27,7 +27,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/system/dept/index.vue b/src/views/system/dept/index.vue
@@ -38,7 +38,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/system/dict/dictDetail.vue b/src/views/system/dict/dictDetail.vue
@@ -16,7 +16,7 @@
           <el-form-item label="字典标签" prop="label">
             <el-input v-model="form.label" style="width: 370px;" />
           </el-form-item>
-          <el-form-item label="字典值">
+          <el-form-item label="字典值" prop="value">
             <el-input v-model="form.value" style="width: 370px;" />
           </el-form-item>
           <el-form-item label="排序" prop="sort">
@@ -84,6 +84,9 @@ export default {
         label: [
           { required: true, message: '请输入字典标签', trigger: 'blur' }
         ],
+        value: [
+          { required: true, message: '请输入字典值', trigger: 'blur' }
+        ],
         sort: [
           { required: true, message: '请输入序号', trigger: 'blur', type: 'number' }
         ]
diff --git a/src/views/system/job/module/form.vue b/src/views/system/job/module/form.vue
@@ -73,7 +73,7 @@
         取消
       </el-button>
       <el-button
-        :loading="crud.cu === 2"
+        :loading="crud.status.cu === 2"
         type="primary"
         @click="crud.submitCU"
       >
diff --git a/src/views/system/menu/index.vue b/src/views/system/menu/index.vue
@@ -89,7 +89,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
@@ -98,7 +98,7 @@
       <el-table-column v-if="columns.visible('name')" :show-overflow-tooltip="true" label="菜单名称" width="125px" prop="name" />
       <el-table-column v-if="columns.visible('icon')" prop="icon" label="图标" align="center" width="60px">
         <template slot-scope="scope">
-          <svg-icon :icon-class="scope.row.icon" />
+          <svg-icon :icon-class="scope.row.icon ? scope.row.icon : ''" />
         </template>
       </el-table-column>
       <el-table-column v-if="columns.visible('sort')" prop="sort" align="center" label="排序">
diff --git a/src/views/system/role/index.vue b/src/views/system/role/index.vue
@@ -51,7 +51,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <el-row :gutter="15">
@@ -165,7 +165,6 @@ export default {
     this.getMenus()
     crudRoles.getLevel().then(data => {
       this.level = data.level
-      console.log(this.level)
     })
     this.$nextTick(() => {
       this.crud.toQuery()
diff --git a/src/views/system/timing/index.vue b/src/views/system/timing/index.vue
@@ -59,7 +59,7 @@
       </el-form>
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
-        <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->
diff --git a/src/views/system/user/index.vue b/src/views/system/user/index.vue
@@ -138,7 +138,7 @@
           </el-form>
           <div slot="footer" class="dialog-footer">
             <el-button type="text" @click="crud.cancelCU">取消</el-button>
-            <el-button :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+            <el-button :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
           </div>
         </el-dialog>
         <!--表格渲染-->
diff --git a/src/views/tools/storage/local/index.vue b/src/views/tools/storage/local/index.vue
@@ -58,7 +58,7 @@
       <div slot="footer" class="dialog-footer">
         <el-button type="text" @click="crud.cancelCU">取消</el-button>
         <el-button v-if="crud.status.add" :loading="loading" type="primary" @click="upload">确认</el-button>
-        <el-button v-else :loading="crud.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
+        <el-button v-else :loading="crud.status.cu === 2" type="primary" @click="crud.submitCU">确认</el-button>
       </div>
     </el-dialog>
     <!--表格渲染-->

Original file line number	Diff line number	Diff line change
`@@ -3,12 +3,15 @@`
`3`	`3`	`.filter-item {`
`4`	`4`	`display: inline-block;`
`5`	`5`	`vertical-align: middle;`
`6`		`- margin: 0 2px 10px 0;`
	`6`	`+ margin: 0 3px 10px 0;`
`7`	`7`	`input {`
`8`	`8`	`height: 30.5px;`
`9`	`9`	`line-height: 30.5px;`
`10`	`10`	`}`
`11`	`11`	`}`
	`12`	`+ .el-button+.el-button {`
	`13`	`+ margin-left: 0 !important;`
	`14`	`+ }`
`12`	`15`	`.el-select__caret.el-input__icon.el-icon-arrow-up{`
`13`	`16`	`line-height: 30.5px;`
`14`	`17`	`}`
`@@ -17,7 +20,7 @@`
`17`	`20`	`vertical-align: middle;`
`18`	`21`	`margin-bottom: 10px;`
`19`	`22`	`height: 30.5px;`
`20`		`- width: 223px;`
	`23`	`+ width: 223px !important;`
`21`	`24`	`}`
`22`	`25`	`}`
`23`	`26`	`.el-avatar {`