Skip to content

Performance issue in SimpleScriptable.isReadOnlySettable #107

Description

@SteveHarney

Hi All,
We have been using HtmlUnit to execute a long list of JUnit tests. As part of our performance profiling of our code it has been identified that SimpleScriptable.isReadOnlySettable is an issue and is accounting for ~10% of our processing.

This particular method is calling Method.getAnnotation(JsxGetter.class) and Method.getAnnotation(CanSetReadOnly.class) potentially for each method on the subclass. The getAnnotation method is time consuming and the results are highly unlikely to change. It would be better if the classes could establish a cache which would eliminate the need to process the unnecessary annotations on every execution on every subclass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions