Skip to content

Improve core shaders warning usability #2191

@Madis0

Description

@Madis0

Request Description

#2043 added a warning about core shaders partially or fully not working. I built 105c326 and tested with Vanilla Tweaks' Warm Glow and the MCCI server.

The idea is great - the user knows what's wrong, which packs are to blame and that not all core shaders are inherintly broken.

The problem is context:

  • The toasts appear over all screens, but the user cannot and will not (during gameplay) take action on all screens
  • If the user missed the toast, or the name on the toast, they won't have any context by the time they open the resource pack screen to edit it
  • Because it appears on every resource reload, it doesn't care if the user already saw one of the warnings (e.g. one user resource pack and one server resource pack)

To fix this, I suggest:

  • Making the toast permanent on
    • Resource pack selection screen (while the concerning packs are enabled)
    • Server edit screen (if the server is known to have the concerning pack)
    • Resource reload splash screen
  • and temporary on:
    • Options/title screen
    • Pause menu
  • but do not show at all on in-game screens.
  • The temporary toast could show only the server resource pack(s) upon server join, because by that time the user would've acknowledged any self-selected packs either way.
  • Ideally you could also mixin into the vanilla "incompatible resource pack" warning screen/red shade for even more "native look", but maintaining that while keeping compatibility with other mods may become annoying.

Metadata

Metadata

Assignees

No one assigned

    Labels

    F-help-wantedFlag: Help wantedS-acceptedStatus: Request accepted but needs volunteerT-enhancementType: Enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions