Fix source loading example crash#1
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: 0-coding <0-coding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The newly added
source/load_mod_from_source_code.pyexample crashed every time it was run.exec("a=b", {})raisedNameErrorbecausebwas not defined in the execution namespace, making the example unusable.Root cause
The executed source code referenced a symbol that was not provided to the isolated namespace passed to
exec.Fix
Seed the execution namespace with
bbefore executing the source code, then print the loaded value. Added a standard-library smoke test that executes the script and asserts the expected output.Validation
python3 source/load_mod_from_source_code.pypython3 source/unittest_to_io.pypython3 -m unittest discover -s tests